[webkit-reviews] review canceled: [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges() : [Attachment 138291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 22:38:05 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 84435: [EFL][DRT] EFL's DRT needs to support
LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435

Attachment 138291: Patch
https://bugs.webkit.org/attachment.cgi?id=138291&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Update patch to pass the icon type with the "icon,changed" signal. Note that
this signal is emitted only on the main frame for consistency.
Indeed, the "icon,received" signal was already existing and is only emitted on
the main frame.


More information about the webkit-reviews mailing list