[webkit-reviews] review granted: [Bug 84387] [chromium] DomStorage event handling mods : [Attachment 138411] events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 16:25:47 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 84387: [chromium] DomStorage event handling mods
https://bugs.webkit.org/show_bug.cgi?id=84387

Attachment 138411: events
https://bugs.webkit.org/attachment.cgi?id=138411&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138411&action=review


ok with a nit.

> Source/WebKit/chromium/src/StorageAreaProxy.cpp:243
> +Page* StorageAreaProxy::findPageWithSessionStorageNamespace(const String&
pageGroupName, const WebKit::WebStorageNamespace& sessionNamespace)

This looks like it can be just a freestanding static function.


More information about the webkit-reviews mailing list