[webkit-reviews] review granted: [Bug 84640] [V8] Fix issue with trying to access a constructor in a frame that has been removed : [Attachment 138436] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 84640: [V8] Fix issue with trying to access a constructor in a frame that
has been removed
https://bugs.webkit.org/show_bug.cgi?id=84640

Attachment 138436: Patch
https://bugs.webkit.org/attachment.cgi?id=138436&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review


>>> LayoutTests/fast/dom/constructor-in-removed-frame.html:17
>>> +		 frame.Window;
>> 
>> Shall we check the value of frame.Window?
> 
> We could but V8 and JSC report different values.
> 
> V8 returns undefined. JSC returns the Window constructor. V8 matches Firefox
and Opera. IE throws access denied.
> 
> Based on that I don't think we should check the actual value.

Sounds reasonable.