[webkit-reviews] review granted: [Bug 83918] REGRESSION (r100311): YummySoup app crashes when trying to print : [Attachment 138402] Fix test failures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 13:34:01 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 83918: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918

Attachment 138402: Fix test failures
https://bugs.webkit.org/attachment.cgi?id=138402&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138402&action=review


> LayoutTests/platform/mac/security/block-test-expected.txt:-4
> -http://255.255.255.255:7/test.jpg - willSendRequest <NSURLRequest URL
http://255.255.255.255:7/test.jpg, main document URL block-test.html, http
method GET> redirectResponse (null)

Yeah, 255.255.255.255:7 is cool too.

> Source/WebCore/loader/SubresourceLoader.cpp:280
> +    if (reachedTerminalState())
> +	   return;

Why is it OK to not call the base class in this case?

> Source/WebCore/loader/SubresourceLoader.cpp:301
> +    if (reachedTerminalState())
> +	   return;

Ditto.

> Source/WebCore/loader/SubresourceLoader.cpp:328
>	   m_resource->stopLoading();

I hope we can move this out in the future, too.


More information about the webkit-reviews mailing list