[webkit-reviews] review denied: [Bug 84135] Support cross-filesystem operations in FileSystem API : [Attachment 138046] Patch

[bugzilla-daemon at webkit.org]

Eric U. <ericu at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 84135: Support cross-filesystem operations in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=84135

Attachment 138046: Patch
https://bugs.webkit.org/attachment.cgi?id=138046&action=review

------- Additional Comments from Eric U. <ericu at chromium.org>
Looks generally good.  Small points below.

View in context: https://bugs.webkit.org/attachment.cgi?id=138046&action=review


> Source/WebCore/Modules/filesystem/chromium/DOMFileSystemChromium.cpp:75
> +	   // FIXME: Remove this clause once
http://codereview.chromium.org/7811006

It landed a while back; mind trimming this dead code while you're in there?
If we don't have an innerURL, the URL isn't valid, and we should return false.

> Source/WebCore/Modules/filesystem/chromium/DOMFileSystemChromium.cpp:129
> +    return KURL(ParsedURLString, url);

Why are we not just returning url?  What does the extra constructor call do?

> Source/WebCore/Modules/filesystem/chromium/DOMFileSystemChromium.cpp:144
> +    // chromium and is validated each time in the chromium port.

This comment needs rewriting for clarity, and "to the chromium" doesn't make
sense.	I realize it isn't a new comment, but deleting it would be better than
leaving it as-is.

> Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp:52
>  namespace {

Make sure you copy all relevant changes into AsyncFileSystemBlackBerry.cpp and
AsyncFileSystemGtk.cpp.