[webkit-reviews] review denied: [Bug 83048] new-webkit-run-tests: handle ref tests from the CSS test suite : [Attachment 138234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 13:00:38 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 83048: new-webkit-run-tests: handle ref tests from the CSS test suite
https://bugs.webkit.org/show_bug.cgi?id=83048

Attachment 138234: Patch
https://bugs.webkit.org/attachment.cgi?id=138234&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
As rniwa says, using abspath_for_test and self._filesystem.abspath() should get
rid of the embedded ".."s. Otherwise the patch looks pretty good.


More information about the webkit-reviews mailing list