[webkit-reviews] review denied: [Bug 84583] Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first. : [Attachment 138320] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 12:16:25 PDT 2012


Andy Estes <aestes at apple.com> has denied Andy Estes <aestes at apple.com>'s
request for review:
Bug 84583: Incremental rendering should be unsuppressed after the load event or
a configurable timeout, whichever occurs first.
https://bugs.webkit.org/show_bug.cgi?id=84583

Attachment 138320: Patch
https://bugs.webkit.org/attachment.cgi?id=138320&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138320&action=review


> Source/WebCore/dom/Document.cpp:1203
> +#if USE(ACCELENRATED_COMPOSITING)

Oops.

> Source/WebKit/mac/WebView/WebView.mm:1519
> +   
settings->setIncrementalRenderingSuppressionTimeoutInSeconds([preferences
incrementalRenderingSuppressionTimeoutInSeconds]);

This has the effect of disabling incremental rendering suppression unless the
preference is actually set. What I actually want in this case is the default
timeout.


More information about the webkit-reviews mailing list