[webkit-reviews] review denied: [Bug 84608] [Chromium] Added a chromium webkit public header file to support different web print scaling options. : [Attachment 138375] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied kmadhusu
<kmadhusu at chromium.org>'s request for review:
Bug 84608: [Chromium] Added a chromium webkit public header file to support
different web print scaling options.
https://bugs.webkit.org/show_bug.cgi?id=84608

Attachment 138375: Patch
https://bugs.webkit.org/attachment.cgi?id=138375&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138375&action=review


How do you plan to use this enum?  It is often easier to review API changes
when it is
clear how the parts will fit together.	This looks like an unused enum :-)

> Source/WebKit/chromium/public/WebPrintScalingOption.h:36
> +enum WebPrintScalingOption {

please fix naming:
http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums