[webkit-reviews] review denied: [Bug 84398] Move LayoutTestController::setValueForUser to Internals : [Attachment 138002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 10:15:11 PDT 2012


Hajime Morrita <morrita at google.com> has denied Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 84398: Move LayoutTestController::setValueForUser to Internals
https://bugs.webkit.org/show_bug.cgi?id=84398

Attachment 138002: Patch
https://bugs.webkit.org/attachment.cgi?id=138002&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
Thanks for taking this! Code looks good. 
r- for bot redness.

GTK bot complains because of missing symbols, which now need to be exported
because WebCoreTestSupport is
a separate library from libwebkitgtk. See Source/autotools/symbols.filter.

Windows bot also needs these symbols to be exported. It doesn't have the
original DRT implementation
so hasn't done that...


More information about the webkit-reviews mailing list