[webkit-reviews] review requested: [Bug 84601] [chromium] Add pause and resume support for accelerated css animations. : [Attachment 138371] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 10:07:16 PDT 2012


vollick at chromium.org has asked	for review:
Bug 84601: [chromium] Add pause and resume support for accelerated css
animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Attachment 138371: Patch
https://bugs.webkit.org/attachment.cgi?id=138371&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #2)
> (From update of attachment 138357 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=138357&action=review
>
> > Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:626
> >  void LayerChromium::suspendAnimations(double time)
>
> Can you name the 'time' variable more descriptively, or otherwise make it
more clear what the variable's base is? Or maybe the conversion below is more
obvious to others

Good point! I've renamed the parameters.


More information about the webkit-reviews mailing list