[webkit-reviews] review requested: [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well : [Attachment 138305] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 01:09:57 PDT 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 84540: JS binding code generator doesn't handle "attribute unsigned long[]"
well
https://bugs.webkit.org/show_bug.cgi?id=84540

Attachment 138305: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=138305&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
I have slightly modified patch.

Instead of using something IsPrimitiveType we should use AvoidInclusionOfType
subroutine.
Added tests for numeric and primitive types.
removed readonly to test both getters/setters. //sorry this increased generated
code :(


More information about the webkit-reviews mailing list