[webkit-reviews] review denied: [Bug 79586] xmlserializer strips xlink from xlink:html svg image tag : [Attachment 133783] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 79586: xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586

Attachment 133783: Patch
https://bugs.webkit.org/attachment.cgi?id=133783&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133783&action=review


> Source/WebCore/ChangeLog:8
> +	   Always write out xlink prefix on href attribute for SVG elements.

This description isn't quite accurate. We're writing out qualified names for
all non-HTML elements.

> Source/WebCore/editing/MarkupAccumulator.cpp:385
> -    if (documentIsHTML)
> +    if (documentIsHTML && element->isHTMLElement())

According to
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serial
izing-html-fragments,
we should be checking attribute's namespace, not element's namespace. So this
won't match the spec if e.g. xml:lang is specified.