[webkit-reviews] review denied: [Bug 83014] [Chromium] PlatformKeyboardEvent::m_windowsVirtualKeyCode should be zero for char events : [Attachment 136963] Rebased

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 22 22:14:25 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Cem Kocagil
<cem.kocagil+webkit at gmail.com>'s request for review:
Bug 83014: [Chromium] PlatformKeyboardEvent::m_windowsVirtualKeyCode should be
zero for char events
https://bugs.webkit.org/show_bug.cgi?id=83014

Attachment 136963: Rebased
https://bugs.webkit.org/attachment.cgi?id=136963&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136963&action=review


> Source/WebKit/chromium/ChangeLog:7
> +

Please explain why you're making this change. r- due to the lack of
description.
Also, can't this be tested by a chromium unit test?


More information about the webkit-reviews mailing list