[webkit-reviews] review granted: [Bug 81854] RadioNodeList support in HTMLFormElement::elements : [Attachment 137700] Update patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 81854: RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Attachment 137700: Update patch
https://bugs.webkit.org/attachment.cgi?id=137700&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137700&action=review


The patch looks fantastic now. Please fix the nits below before you land it or
I'll gladly cq+ if you upload a new patch.

> Source/WebCore/html/RadioNodeList.cpp:72
> +void RadioNodeList::setValue(const String& val)

Please don't use abbreviations like val.

> LayoutTests/fast/forms/form-collection-radio-node-list.html:41
> +    </form>

You should output this form for consistency.

> LayoutTests/fast/forms/form-collection-radio-node-list.html:68
> +debug("Checking value IDL attribute on the RadioNodeList");
> +shouldBe('radioNodeList.value', '""');
> +shouldBe('radioNodeList.value = "inputRadioValue";
radioNodeList[2].checked', 'true');

Maybe we should also check the name of class? (i.e. prototype name).