[webkit-reviews] review canceled: [Bug 84275] [chromium] Image masks are considered opaque incorrectly : [Attachment 138214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 21 16:54:05 PDT 2012


Dana Jansens <danakj at chromium.org> has canceled Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84275: [chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Attachment 138214: Patch
https://bugs.webkit.org/attachment.cgi?id=138214&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138214&action=review


>> Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp:334
>> +	    markRectAsNonOpaque(deviceClipRect);
> 
> Do you need to check for deviceClipIsARect here before you use deviceClipRect
and maybe do a markAllAsNonOpaque if it's not? Can you add a test for a layer
without a clip that destroys opacity?

oh yes


More information about the webkit-reviews mailing list