[webkit-reviews] review requested: [Bug 84519] [chromium] Animations waiting for a synchronized start time should never be marked finished. : [Attachment 138217] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 19:38:01 PDT 2012


vollick at chromium.org has asked	for review:
Bug 84519: [chromium] Animations waiting for a synchronized start time should
never be marked finished.
https://bugs.webkit.org/show_bug.cgi?id=84519

Attachment 138217: Patch
https://bugs.webkit.org/attachment.cgi?id=138217&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #2)
> (From update of attachment 138216 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=138216&action=review
>
> Nice. Might tweak the phrasing but LGTM.
>
> > Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp:193
> > +// Tests animations that are waiting for a synchronized start time do not
finish.
>
> DoNotFinishIfTheyWaitLongerToStartThanTheirDuration?

Done. I think I may have broken some sort of record with this test name. :)


More information about the webkit-reviews mailing list