[webkit-reviews] review denied: [Bug 83980] Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2 : [Attachment 138187] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 20 17:12:56 PDT 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 83980: Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt
webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980
Attachment 138187: Patch.
https://bugs.webkit.org/attachment.cgi?id=138187&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think this goes too far in the other direction :)
We try to avoid seemingly arbitrary platform #ifdefs, because they make the
code very confusing and hard to maintain.
This also interacts with code in RLC::requireLayerForPosition(), so that needs
to be communicated in the code somehow (perhaps by a
FIXED_POSITION_CREATES_STACKING_CONTEXT #ifdef).
More information about the webkit-reviews
mailing list