[webkit-reviews] review denied: [Bug 63941] Compilation bug - gcc 4.6.0 and c++0x : [Attachment 138115] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Michelangelo De Simone
<michelangelo at webkit.org>'s request for review:
Bug 63941: Compilation bug - gcc 4.6.0 and c++0x
https://bugs.webkit.org/show_bug.cgi?id=63941

Attachment 138115: Patch
https://bugs.webkit.org/attachment.cgi?id=138115&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138115&action=review


>> Tools/qmake/mkspecs/features/unix/default_post.prf:22
>> +	    QT_GCC_VERSION = $$system(gcc -dumpversion)
> 
> linux-g++* also includes linux-g++-maemo where the compiler is called
arm-linux-gnuabi-gcc, so this is not correct.
> QMAKE_CC would be better as stated above.

Also, this should probably be in default_pre instead, so that the variables can
be used in pro/pri files as well.