[webkit-reviews] review granted: [Bug 84476] JSGarbageCollect should not call collectAllGarbage() : [Attachment 138139] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 84476: JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476

Attachment 138139: Patch
https://bugs.webkit.org/attachment.cgi?id=138139&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Let's fix the FIXME by taking advantage of our new callback, like so:

- Cancel the GC timer at the start of collection (rename didCollect to
willCollect)
- If collection causes a didAbandonObjectGraph, it can now start the timer,
which will, in fact, cause another collection later.

In the same patch, you can remove the isBusy() check, since
didAbandonObjectGraph is safe to call while the heap is busy.