[webkit-reviews] review denied: [Bug 84275] [chromium] Image masks are considered opaque incorrectly : [Attachment 138022] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84275: [chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Attachment 138022: Patch
https://bugs.webkit.org/attachment.cgi?id=138022&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138022&action=review


> Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp:162
> +	   clippedBounds.setEmpty();

This function is really inconsistent about if and what it sets clippedBounds to
when returning false.

> Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp:197
> +    SkRect clippedBounds;

Whoa there, potentially uninitialized SkRect.

> Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp:354
> +    if (clippedBounds.isEmpty())
> +	   return;

Should clippedBounds be initialized to layerOpaqueRect in the case not having a
clip? I'm guessing here that clipped bounds being empty is trying to imply that
the entire layer is clipped away?