[webkit-reviews] review granted: [Bug 84447] Web Inspector: follow up to r114729: more @return annotations added. : [Attachment 138087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 09:17:43 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 84447: Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447

Attachment 138087: Patch
https://bugs.webkit.org/attachment.cgi?id=138087&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138087&action=review


> Source/WebCore/inspector/front-end/Resource.js:54
> +    /** @type {?string} */ this._content;

Type annotation should go above the field and the field should be initialized
here.

> Source/WebCore/inspector/front-end/ResourceUtils.js:113
> +    var parsedURL = new WebInspector.ParsedURL(this.toString());

Why do you need to call toString()? Would @this {string} annotation help?


More information about the webkit-reviews mailing list