[webkit-reviews] review granted: [Bug 84376] [Chromium] Call memoryUsageMB directly : [Attachment 138025] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 01:26:49 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 84376: [Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376

Attachment 138025: Patch
https://bugs.webkit.org/attachment.cgi?id=138025&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138025&action=review


> Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp:39
> +// Returns the current space allocated for the pagefile, in MB.
> +// That is committed size for Windows and virtual memory size for POSIX

Nit: Put this comment in the header file.

Nit: The trailing period please. "for POSIX."


More information about the webkit-reviews mailing list