[webkit-reviews] review denied: [Bug 84417] [Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly : [Attachment 138035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 01:16:56 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 84417: [Chromium] Remove PlatformSupport::loadPlatformImageResource, call
loadResource directly
https://bugs.webkit.org/show_bug.cgi?id=84417

Attachment 138035: Patch
https://bugs.webkit.org/attachment.cgi?id=138035&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138035&action=review


> Duplicates some code between ImageChromium.cpp and ImageChromiumMac.mm.
Problem?

Yeah, we want to avoid duplication.

> Source/WebCore/platform/graphics/chromium/ImageChromiumMac.mm:41
> +#include <public/Platform.h>

Nit: This header is duplicated.


More information about the webkit-reviews mailing list