[webkit-reviews] review denied: [Bug 71771] Inserting empty html moves caret : [Attachment 137853] Patch.

Thu Apr 19 22:46:24 PDT 2012

Ryosuke Niwa <rniwa at webkit.org> has denied Antaryami Pandia (apandia)
<antaryami.pandia at motorola.com>'s request for review:
Bug 71771: Inserting empty html moves caret
https://bugs.webkit.org/show_bug.cgi?id=71771

Attachment 137853: Patch.
https://bugs.webkit.org/attachment.cgi?id=137853&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137853&action=review

> LayoutTests/editing/inserting/insert-empty-html.html:6
> +<head>
> +<script src="../../fast/js/resources/js-test-pre.js"></script>
> +</head>
> +

You don't need to have a head for this. You can just move js-test-pre.js to
body.

> LayoutTests/editing/inserting/insert-empty-html.html:19
> +    var sel = window.getSelection();

Please don't use abbreviations like sel.

> LayoutTests/editing/inserting/insert-empty-html.html:23
> +    // Set the caret position

This comment repeats the code. Please remove.

> LayoutTests/editing/inserting/insert-empty-html.html:26
> +    // Insert the empty html

Ditto.