[webkit-reviews] review denied: [Bug 84351] [Chromium] datalist: Inconsistent behavior of HTMLInputElement::list : [Attachment 138012] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 84351: [Chromium] datalist: Inconsistent behavior of HTMLInputElement::list
https://bugs.webkit.org/show_bug.cgi?id=84351

Attachment 138012: Patch
https://bugs.webkit.org/attachment.cgi?id=138012&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138012&action=review


> Source/WebCore/html/InputType.cpp:624
> +    return theme->supportsDataListUI(formControlType());

We should ask RenderTheme about it only for supported types defined by the
standard.

> Source/WebCore/rendering/RenderTheme.h:135
> +    virtual bool supportsDataListUI(const AtomicString& type) const {
printf("XX\n"); return false; }

printf

> Source/WebCore/rendering/RenderThemeChromiumMac.mm:77
> +    return type == InputTypeNames::text();

We supports email, tel, search, url, and number, right?