[webkit-reviews] review denied: [Bug 75594] Adding feature that suggests turning on the encoding detector. : [Attachment 128233] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 17:34:59 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 75594: Adding feature that suggests turning on the encoding detector.
https://bugs.webkit.org/show_bug.cgi?id=75594

Attachment 128233: Patch
https://bugs.webkit.org/attachment.cgi?id=128233&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128233&action=review


I don't understand the context at all.	Anyway the patch is large and EWSs are
purple. Creating KanjiCode.{cpp,h} should be a separated patch.

> Source/WebCore/platform/text/KanjiCode.cpp:3
> +/*
> + * Copyright (C) 2012 Google Inc. All rights reserved.
> + *

We must respect the copyright notice of the original code.


More information about the webkit-reviews mailing list