[webkit-reviews] review granted: [Bug 76152] Incorrect handling of CSS escape sequences that encode surrogates : [Attachment 131605] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 19 16:53:05 PDT 2012
Kent Tamura <tkent at chromium.org> has granted Szilard Ledan
<szledan at inf.u-szeged.hu>'s request for review:
Bug 76152: Incorrect handling of CSS escape sequences that encode surrogates
https://bugs.webkit.org/show_bug.cgi?id=76152
Attachment 131605: patch
https://bugs.webkit.org/attachment.cgi?id=131605&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131605&action=review
> Source/WebCore/css/CSSParser.cpp:7759
> + // Lead/High surrogate character
This comment looks useless.
> Source/WebCore/css/CSSParser.cpp:7761
> + *result = U16_LEAD(unicode);
> + ++result;
We can write this as: *result++ = U16_LEAD(unicode);
> Source/WebCore/css/CSSParser.cpp:7762
> + // Trail/Low surrogate character
This comment looks useless.
More information about the webkit-reviews
mailing list