[webkit-reviews] review granted: [Bug 84400] setPageScaleFactor should setScrollPosition if scale is unchanged : [Attachment 138001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:47:03 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 84400: setPageScaleFactor should setScrollPosition if scale is unchanged
https://bugs.webkit.org/show_bug.cgi?id=84400

Attachment 138001: Patch
https://bugs.webkit.org/attachment.cgi?id=138001&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138001&action=review


Looks good, but a better explanation for the lack of tests is needed

> Source/WebCore/ChangeLog:14
> +	   No new tests.

Why?


More information about the webkit-reviews mailing list