[webkit-reviews] review denied: [Bug 71851] Implement script MIME restrictions for X-Content-Type-Options: nosniff : [Attachment 114387] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:41:18 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 71851: Implement script MIME restrictions for X-Content-Type-Options:
nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851

Attachment 114387: Patch
https://bugs.webkit.org/attachment.cgi?id=114387&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
As per the webkit-dev discussion, the flag should be off for the non-chromium
ports. Each port should enable it explicitly since they'll need to add extra
port-specific code. The way you handle the tests for a disabled flag is to add
the tests to the Skipped list of the ports that have it disabled.

Other than that and Adam's one comment about the newline, the patch looks fine
to me.


More information about the webkit-reviews mailing list