[webkit-reviews] review denied: [Bug 83865] [EFL] Add Web Inspector to WebKit-EFL : [Attachment 137052] Patch

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 83865: [EFL] Add Web Inspector to WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=83865

Attachment 137052: Patch
https://bugs.webkit.org/attachment.cgi?id=137052&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=137052&action=review


It's a good start, but there are some issues to take care first.

> Source/WebKit/ChangeLog:6
> +	   [EFL] Add Web Inspector to WebKit-EFL
> +	   https://bugs.webkit.org/show_bug.cgi?id=83865
> +
> +	   Add EFL port implementation for Web Inspector

Please try to be more descriptive in the changelog entries.

> Source/WebKit/PlatformEfl.cmake:291
> +    FILE(COPY ${WEB_INSPECTOR_DATA} DESTINATION ${WEB_INSPECTOR_DIR})
> +    FILE(COPY ${WEB_INSPECTOR_UGLIFYJS_DATA} DESTINATION
${WEB_INSPECTOR_UGLIFYJS_DIR})
> +    FILE(COPY ${WEB_INSPECTOR_IMAGES_DATA} DESTINATION
${WEB_INSPECTOR_IMAGES_DIR})

This will be executed only during the build process; unless I'm mistaken, the
inspector won't work properly unless these are actually installed.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:34
> +    InspectorFrontendClientEfl* inspectorFrontendClient =
(InspectorFrontendClientEfl*)userData;

C++-style cast.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:36
> +	   inspectorFrontendClient->destroyInspectorWindow(true);

I'm not sure what 'true' means here; consider using an enum.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:41
> +public:
> +    virtual ~InspectorFrontendSettingsEfl() { }

No need to implement this.