[webkit-reviews] review denied: [Bug 84217] Binding: IDL type DOMString[] shouldn't match null : [Attachment 137641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:29:40 PDT 2012


Erik Arvidsson <arv at chromium.org> has denied  review:
Bug 84217: Binding: IDL type DOMString[] shouldn't match null
https://bugs.webkit.org/show_bug.cgi?id=84217

Attachment 137641: Patch
https://bugs.webkit.org/attachment.cgi?id=137641&action=review

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137641&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1227
> +	       push(@andExpression, "((${value}.isObject() &&
asObject(${value})->inherits(&JSArray::s_info)))");

inherits is not the same as IsArray in the V8 case.

The following would match inherits but fail to match IsArray.

var obj = Object.create([]);

Does the spec require [[Class]] to be "Array" or does it require
Array.prototype to be on the prototype chain?


More information about the webkit-reviews mailing list