[webkit-reviews] review denied: [Bug 51978] Marquee inside table incorrectly sized : [Attachment 137888] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has denied arpitabahuguna at gmail.com's
request for review:
Bug 51978: Marquee inside table incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=51978

Attachment 137888: Patch
https://bugs.webkit.org/attachment.cgi?id=137888&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137888&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:2030
> +    if (e && e->hasTagName(marqueeTag)) {
>	   style->setOverflowX(OMARQUEE);
> -    else if (style->overflowX() == OVISIBLE && style->overflowY() !=
OVISIBLE)
> +	   style->setOverflowY(OMARQUEE);
> +    }

That's plain wrong: by default, marquee has those set-up and we allow people to
override them. Do you have any proof that this is actually breaking any
website? If not, that's how it's implemented in WebKit and allowing people to
override that is good! (like <div style="display:table-cell">). We do need to
drop our overflow: -webkit-marquee extension to fix this bug properly but
that's another story.