[webkit-reviews] review denied: [Bug 84318] AsyncFileSystem::openFileSystem is missing parameters : [Attachment 137850] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 84318: AsyncFileSystem::openFileSystem is missing parameters
https://bugs.webkit.org/show_bug.cgi?id=84318

Attachment 137850: Patch
https://bugs.webkit.org/attachment.cgi?id=137850&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137850&action=review


> Source/WebCore/platform/AsyncFileSystem.cpp:67
> +void AsyncFileSystem::openFileSystem(ScriptExecutionContext*, const String&
basePath, const String& storageIdentifier, Type type, long long, bool,
PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

ScriptExecutationContext is not a platofrm concept.  I believe this is a
layering violation.

> Source/WebCore/platform/gtk/AsyncFileSystemGtk.cpp:50
> +void AsyncFileSystem::openFileSystem(SecurityOrigin*, const String&
basePath, const String& storageIdentifier, Type type, long long, bool,
PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

Similarly, I believe this to be a layering violation.