[webkit-reviews] review canceled: [Bug 20040] Vertical border spacing is doubled between table row groups : [Attachment 134285] Patch to remove extra border spacing across table sections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:07:19 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has canceled Kishore Bolisetty
<kbolisetty at innominds.com>'s request for review:
Bug 20040: Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Attachment 134285: Patch to remove extra border spacing across table sections
https://bugs.webkit.org/attachment.cgi?id=134285&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134285&action=review


Sorry, it looks like this bug slipped through my mail box. There is still one
test failling which mandates another pass.

>> LayoutTests/platform/chromium/test_expectations.txt:4126
>> +//BUGWK37244 : tables/mozilla/bugs/bug27038-2.html = IMAGE+TEXT
> 
> That doesn't look right. Why are you removing those entries without
rebaselining?

OK, you really shouldn't touch that as part of this change. Unless they are now
passing (in which case you remove them and explain it), your change is already
big enough without this orthogonal change.


More information about the webkit-reviews mailing list