[webkit-reviews] review granted: [Bug 84328] Media Stream API: Piece of code cleanup for the chromium port : [Attachment 137881] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:04:31 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Jeremy Mao <yujie.mao at intel.com>'s
request for review:
Bug 84328: Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328

Attachment 137881: Patch
https://bugs.webkit.org/attachment.cgi?id=137881&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137881&action=review


> Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h:53
> +    virtual void requestUserMedia(const WebUserMediaRequest&, const
WebVector<WebMediaStreamSource>&, const WebVector<WebMediaStreamSource>&);

We had better append 'OVERRIDE' to this.


More information about the webkit-reviews mailing list