[webkit-reviews] review denied: [Bug 77056] Adding a favicon may trigger an invalid didChangedIcon event : [Attachment 124030] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:03:26 PDT 2012


Eric Seidel <eric at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 77056: Adding a favicon may trigger an invalid didChangedIcon event
https://bugs.webkit.org/show_bug.cgi?id=77056

Attachment 124030: Patch
https://bugs.webkit.org/attachment.cgi?id=124030&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124030&action=review


How do we test this?

> Source/WebCore/ChangeLog:3
> +	   Adding a favicon may trigger an invalid didChangedIcon event

I think you mean "didChangeIcon"?  "didChanged" doesn't make much sense.


More information about the webkit-reviews mailing list