[webkit-reviews] review denied: [Bug 63807] fast/loader/create-frame-in-DOMContentLoaded.html asserting in FrameLoader::loadWithDocumentLoader on Windows since it was added : [Attachment 131588] Patch v2

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Mustafizur Rahaman( :rahaman)
<mrahaman at innominds.com>'s request for review:
Bug 63807: fast/loader/create-frame-in-DOMContentLoaded.html asserting in
FrameLoader::loadWithDocumentLoader on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=63807

Attachment 131588: Patch v2
https://bugs.webkit.org/attachment.cgi?id=131588&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131588&action=review


This change seems strange to me, but the link to the build output is dead, so
I'm short on context. Regardless, I'm pretty sure that this isn't the right
place to exit for this particular case.

> Source/WebCore/loader/FrameLoader.cpp:715
> +    if (m_stateMachine.creatingInitialEmptyDocument())
> +	   return;

It looks like this patch is causeing test failures (based on the cr-linux bot
output). This seems like an overly broad place to do this check anyway. I would
suggest trying it in Document::implicitClose().