[webkit-reviews] review denied: [Bug 80713] Add new methods to FrameLoaderClient so different WebKit ports can customize the ResourceRequest when it is created. : [Attachment 131621] Add GStreamer fix back.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 15:49:46 PDT 2012


Nate Chapin <japhet at chromium.org> has denied Lyon Chen <liachen at rim.com>'s
request for review:
Bug 80713: Add new methods to FrameLoaderClient so different WebKit ports can
customize the ResourceRequest when it is created.
https://bugs.webkit.org/show_bug.cgi?id=80713

Attachment 131621: Add GStreamer fix back.
https://bugs.webkit.org/attachment.cgi?id=131621&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I'm inclined to agree with ap that adding these new callbacks is not the right
answer, especially for the subresource case. 

Since we don't do policy checks for subresources, dispatchWillSendRequest()
seem like the right time for them. For the policy checks for main resource,
perhaps we can approximate the TargetType, especially since there should be
only 2 possibilities, then just set the real TargetType in
dispatchWillSendRequest() as well?


More information about the webkit-reviews mailing list