[webkit-reviews] review granted: [Bug 78491] [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+ : [Attachment 134053] Patch Proposal + Unit Tests + Docs

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 78491: [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=78491

Attachment 134053: Patch Proposal + Unit Tests + Docs
https://bugs.webkit.org/attachment.cgi?id=134053&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
So after talking with Gustavo I think we agree that the API should be a little
different here. Instead of select_files not updated selected_files, we think
that it should simply replace request->priv->selectedFiles with the selected
files. That would turn
webkit_file_chooser_request_get_previously_selected_files into
webkit_file_chooser_request_get_selected_files and make the documentation and
API a lot simpler. 

Suggestion for the documentation for
webkit_file_chooser_request_get_selected_files: Initially, the return value of
this method contains any files selected in previous file chooser requests for
this HTML input element. Once webkit_file_chooser_request_select_files, the
value will reflect whatever file are given. 

Otherwise, the patch looks great. Feel free to commit with this change or
reupload a new patch.