[webkit-reviews] review granted: [Bug 80360] 1ex should equal .5em when the font has no x-height metric : [Attachment 133724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 15:26:57 PDT 2012


Eric Seidel <eric at webkit.org> has granted David Barr <davidbarr at chromium.org>'s
request for review:
Bug 80360: 1ex should equal .5em when the font has no x-height metric
https://bugs.webkit.org/show_bug.cgi?id=80360

Attachment 133724: Patch
https://bugs.webkit.org/attachment.cgi?id=133724&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133724&action=review


> Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp:109
> +	   m_fontMetrics.setHasXHeight(false);

You might want to explain this line here with a comment.


More information about the webkit-reviews mailing list