[webkit-reviews] review denied: [Bug 73300] ExecutableAllocator::cacheFlush() should flush valgrind's caches : [Attachment 116934] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 15:23:22 PDT 2012


Eric Seidel <eric at webkit.org> has denied Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 73300: ExecutableAllocator::cacheFlush() should flush valgrind's caches
https://bugs.webkit.org/show_bug.cgi?id=73300

Attachment 116934: Patch
https://bugs.webkit.org/attachment.cgi?id=116934&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not convinced this is a good patch.  Why don't we implement our own macros
which optionally compile to Valgrind macros when valgrind is installed/enabled.


More information about the webkit-reviews mailing list