[webkit-reviews] review canceled: [Bug 84275] [chromium] Image masks are considered opaque incorrectly : [Attachment 137984] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has canceled Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84275: [chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Attachment 137984: Patch
https://bugs.webkit.org/attachment.cgi?id=137984&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
(In reply to comment #5)
> > Doesn't doing this clear+add depend on the type of composite operation? Do
you always need to do the didDrawUnbounded? (Also, it's kind of weird to say
didDrawUnbounded, since it seems like you know what the paint rect is here?)

Hm, what's wrong here is that these need to combined into a single operation.
What we want is a bounded chance to "preserveOpaque" under the layer's
opaqueRect. Not to clear and then "preserveOpaque" over what we just cleared to
be non-opaque.