[webkit-reviews] review denied: [Bug 71994] Fix IOSurface-related WebCoreSystemInterface defines. : [Attachment 114426] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 71994: Fix IOSurface-related WebCoreSystemInterface defines.
https://bugs.webkit.org/show_bug.cgi?id=71994

Attachment 114426: Patch
https://bugs.webkit.org/attachment.cgi?id=114426&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114426&action=review


ap seems to be objecting, and this patch just seems confusing in its utility to
me.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This will cause the CQ to fail this patch.

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:259
> +#if PLATFORM(MAC) && USE(CA)
>  extern CGContextRef (*wkIOSurfaceContextCreate)(IOSurfaceRef surface,
unsigned width, unsigned height, CGColorSpaceRef colorSpace);
> +#endif

Why do we have a PLATFORM(MAC) check inside mac/?