[webkit-reviews] review denied: [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors : [Attachment 130705] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 9767: WebPreference methods setAllowsAnimatedImages: and
setAllowsAnimatedImageLooping: don't actually affect WebView behaviors
https://bugs.webkit.org/show_bug.cgi?id=9767

Attachment 130705: Patch
https://bugs.webkit.org/attachment.cgi?id=130705&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130705&action=review


> Source/WebCore/ChangeLog:8
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: fast/images/disallow-animated-images.html

This needs to have some explanation of what the change is doing.

> Source/WebCore/platform/graphics/BitmapImage.cpp:454
> -    if (!skippingFrames && imageObserver()->shouldPauseAnimation(this))
> +    if (imageObserver()->shouldPauseAnimation(this))

Why was !skippingFrames removed?

> Source/WebCore/rendering/RenderObject.cpp:2593
> +    return !document()->inPageCache() && !document()->view()->isOffscreen()
&& (!settings || settings->allowAnimatedImages());

Does this also affect static images, not just animating ones?