[webkit-reviews] review denied: [Bug 29993] Zooming while a CSS animation is running does not recompute endpoints : [Attachment 115469] Updated patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ariya Hidayat
<ariya.hidayat at gmail.com>'s request for review:
Bug 29993: Zooming while a CSS animation is running does not recompute
endpoints
https://bugs.webkit.org/show_bug.cgi?id=29993

Attachment 115469: Updated patch
https://bugs.webkit.org/attachment.cgi?id=115469&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115469&action=review


> Source/WebCore/page/animation/CompositeAnimation.cpp:209
> +	       int numAnims = targetStyle->animations()->size();

Shouldn't this be a size_t?

> Source/WebCore/page/animation/CompositeAnimation.cpp:212
> +		   AtomicString animationName(anim->name());

Why make the AtomicString if you're going to continue two lines below?

> Source/WebCore/page/animation/CompositeAnimation.cpp:217
> +		   RefPtr<KeyframeAnimation> keyframeAnim =
m_keyframeAnimations.get(animationName.impl());

Does this actually need an AtomicString?

> Source/WebCore/page/animation/CompositeAnimation.cpp:219
> +		   m_keyframeAnimations.set(animationName.impl(),
keyframeAnim);

Why does it need to be put back in the hash map?

> Source/WebCore/page/animation/KeyframeAnimation.h:57
> +    void updateKeyframes(RenderObject* renderer, RenderStyle*
unanimatedStyle);

'renderer' can be removed.