[webkit-reviews] review denied: [Bug 84292] KeywordLookupGenerator.py should take an output file as an argument : [Attachment 137970] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Don Olmstead
<don.olmstead at am.sony.com>'s request for review:
Bug 84292: KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292

Attachment 137970: Patch
https://bugs.webkit.org/attachment.cgi?id=137970&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review


> Source/JavaScriptCore/KeywordLookupGenerator.py:32
> +if (len(sys.argv) > 2):

We should do the argument parsing separately, instead of re-using the args
array in two places here.  Otherwise seems OK.	A hack, but OK.