[webkit-reviews] review granted: [Bug 83095] apple.com top navigation bar appears inside video during full screen exit animation : [Attachment 136245] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 83095: apple.com top navigation bar appears inside video during full screen
exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095

Attachment 136245: Patch
https://bugs.webkit.org/attachment.cgi?id=136245&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136245&action=review


> Source/WebCore/ChangeLog:22
> +	   * dom/Document.cpp:
> +	   (WebCore::Document::webkitWillExitFullScreenForElement):
> +	   (WebCore::Document::webkitDidExitFullScreenForElement):
> +
> +	   To facilitate writing reproducible LayoutTests, expose
webkitWill/Did/Enter/ExitFullScreen
> +	   from the Internals object, so scripts can call them explicitly:
> +	   * testing/Internals.cpp:
> +	   (WebCore::Internals::webkitWillEnterFullScreenForElement):
> +	   (WebCore::Internals::webkitDidEnterFullScreenForElement):
> +	   (WebCore::Internals::webkitWillExitFullScreenForElement):
> +	   (WebCore::Internals::webkitDidExitFullScreenForElement):

Nit: having comments about what changed in each function would have made this
much easier for someone that doesn't know so much about fullscreen (me) review
this.

> Source/WebCore/dom/Document.cpp:-5448
> -    if (!attached() || inPageCache())
> -	   return;

Nit: please add a comment about why this is no longer necessary to the
ChangLog.

> Source/WebCore/dom/Document.cpp:-5457
> -    if (!attached() || inPageCache())

Ditto.

> LayoutTests/fullscreen/full-screen-exit-animation-stacking-context.html:7
> +	       function init() {

Nit: Function opening brace on its own line please. Here and throughout the
file.