[webkit-reviews] review denied: [Bug 53493] DevTools: assertion failure upon devtools window reopen. : [Attachment 137883] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 19 09:10:06 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 53493: DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493
Attachment 137883: Patch
https://bugs.webkit.org/attachment.cgi?id=137883&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137883&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:75
> + m_page->inspector()->destroyInspectorPage();
It sounds like you should inline destroyInspectorPage into didClose in the
WebInspector instead.
More information about the webkit-reviews
mailing list