[webkit-reviews] review granted: [Bug 84331] Web Inspector: introduce styles panel as an experiment : [Attachment 137885] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 84331: Web Inspector: introduce styles panel as an experiment
https://bugs.webkit.org/show_bug.cgi?id=84331

Attachment 137885: Patch
https://bugs.webkit.org/attachment.cgi?id=137885&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137885&action=review


> Source/WebCore/inspector/front-end/StylesPanel.js:51
> +    this._navigatorView = this._navigator.view;

Is this field needed?

> Source/WebCore/inspector/front-end/StylesPanel.js:69
> +

Please remove this line.

> Source/WebCore/inspector/front-end/StylesPanel.js:154
> +	   var sourceFrame = this._showFile(uiSourceCode);

_showFile does not return anything. Did you mean:
this._showFile(uiSourceCode);
var sourceFrame = this._sourceFramesForResource.get(uiSourceCode);