[webkit-reviews] review requested: [Bug 84246] [Qt] add LayoutTestController::setPrinting support to Qt unit tests : [Attachment 137902] patch that makes the Qt port properly handle setPrinting when creating pixel tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 19 07:55:13 PDT 2012
Milian Wolff <milian.wolff at kdab.com> has asked for review:
Bug 84246: [Qt] add LayoutTestController::setPrinting support to Qt unit tests
https://bugs.webkit.org/show_bug.cgi?id=84246
Attachment 137902: patch that makes the Qt port properly handle setPrinting
when creating pixel tests
https://bugs.webkit.org/attachment.cgi?id=137902&action=review
------- Additional Comments from Milian Wolff <milian.wolff at kdab.com>
- get rid of QWebFrame::paintPagesWithBoundaries, push implementation to
DRTSupportQt
- return QImage instead of taking QImage& as argument in
DRTSupportQt::paintPagesWithBoundaries
Thanks Simon, that really was badly done before.
More information about the webkit-reviews
mailing list